An excellent choice to gain experience or as a career. (Note: I am retired)
Pros
Pay equivalent to civilian occupations. Great benefits. Pride in service. Superb educational opportunities in an occupational specialty and/or college benefits. Opportunities for travel. Varying degrees of adventure and personal risk, depending on the chosen Military Occupational Specialty. Excellent retirement benefits for those who choose to make a career of it and can stay competitive with their peers. Currently, respect for veterans is at an all-time high.
Cons
An occasional "hardship tour," meaning your family cannot accompany you. Varying degrees of personal risk, depending on the political situation and the specialty one chooses. An Up or Out policy that means if you are not promoted to a certain rank within a specified time limit, you will be discharged. Less than 50% of enlisted and officers who want to make a career of it can do so. Some civilian employers don't care what you did in the Army, but others will not be convinced that your military experience is transferable to their corporate culture and needs.